Bug 248627
| Summary: | Remove EditingAppleTabSpan class handling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | joone, rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another about removing old code:
Blink Code - https://chromium.googlesource.com/chromium/src.git/+/013ac5eaf30c02dfa356ba5399da43eb9f368040
Webkit GitHub Source (Example) - https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/HTMLInterchange.h#L41 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L804 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/Editing.cpp#L823 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L1075
Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103143134>
Ryosuke Niwa
createTabSpanElement is still used. We can't remove this code yet.
Ahmad Saleem
NOTE - This causes regression and it was fixed in Blink with this commit - https://chromium.googlesource.com/chromium/src.git/+/52d55d36c78e4772e0e3499409dc6f6dcabde00e