Bug 248626
| Summary: | Remove Apple-style-span CSS class support | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ntim, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another about removing old code:
Blink Code - https://chromium.googlesource.com/chromium/src.git/+/5b32d74c7168caa99fd78792166b0c7e03ac1515 & https://chromium.googlesource.com/chromium/src.git/+/a6290b25704a33a38ea24f338ebe2360437580af
Webkit GitHub Source (Example) - https://github.com/WebKit/WebKit/blob/2c298496904ce18b232566e9677e3122e1018b88/Source/WebCore/editing/ApplyStyleCommand.cpp#L66 & https://github.com/WebKit/WebKit/blob/bb23e4eae6409a6dc22a4499c3ac9bdf7a4e56df/Source/WebCore/rendering/RenderTreeAsText.cpp#L138
Just wanted to raise bug to remove it after input from others that it is not used internally and we can remove it safely.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
We could consider deleting that code now although there isn't much upside to it. The amount of code that can be removed is rather small.
Radar WebKit Bug Importer
<rdar://problem/103143023>
Ahmad Saleem
I have this here as Draft PR but still working locally. For some reason, it leads to crashes of multiple tests. Still working locally to understand the bugs:
https://github.com/WebKit/WebKit/pull/11841
Any help or pointer would be great.