Bug 248595

Summary:	Assertions in database and ITP code cause crashes when running tests in debug builds
Product:	WebKit	Reporter:	Darin Adler <darin>
Component:	Tools / Tests	Assignee:	Darin Adler <darin>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	sihui_liu, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Description Darin Adler 2022-12-01 04:34:22 PST

I’ve had lots of trouble running tests lately, with the network process crashing.

This turns out to be because the database code asserts when it runs into errors accessing databases on disk. I don’t think this is a good design pattern, but also it’s a huge practical problem when just trying to run tests. I suggest we just remove those assertions.

Comment 1 Radar WebKit Bug Importer 2022-12-01 04:35:07 PST

<rdar://problem/102855630>

Comment 2 Darin Adler 2022-12-01 04:40:39 PST

Pull request: https://github.com/WebKit/WebKit/pull/7018

Comment 3 EWS 2022-12-01 07:50:43 PST

Committed 257237@main (28b0771a66f1): <https://commits.webkit.org/257237@main>

Reviewed commits have been landed. Closing PR #7018 and removing active labels.