Bug 248564

Summary:	Refactor RenderBox:sizesLogicalWidthToFitContent()
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2022-11-30 15:30:49 PST

Hi Team,

While going through Blink Commit, I came across following refactoring to remove comment and logic, which was not clear.

Blink Commit - https://src.chromium.org/viewvc/blink?revision=170695&view=revision

Webkit GitHub - https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2740 & https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2812 & https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.cpp#L2822

and https://github.com/WebKit/WebKit/blob/8e087fe5157f63a97276f5f3155ff14974929491/Source/WebCore/rendering/RenderBox.h#L458

It will remove comment about being strange code.

Just wanted to raise this bug so it can be tried.

Thanks!

Comment 1 Radar WebKit Bug Importer 2022-12-07 15:31:18 PST

<rdar://problem/103092634>

Comment 2 Ahmad Saleem 2023-10-03 11:34:45 PDT

It fails here:

https://searchfox.org/wubkat/source/Source/WebCore/dom/Document.cpp#2478

with following error:

reference to type 'const Length' could not bind to an rvalue of type 'WebCore::SizeType'
  ...currRenderer->needsLayout() && currentBox->sizesLogicalWidthToFitContent(MainOrPreferredSize)))