Bug 248556

Summary:	WebDriver: Get Element Rect should not round to integer values
Product:	WebKit	Reporter:	Patrick Angle <pangle>
Component:	WebDriver	Assignee:	Patrick Angle <pangle>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bburg, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Patrick Angle

Reported 2022-11-30 13:57:37 PST

The following tests fail as a result of this issue: webdriver/tests/get_element_rect/get.py::test_basic webdriver/tests/get_element_rect/user_prompts.py::test_accept[capabilities0-alert-None] webdriver/tests/get_element_rect/user_prompts.py::test_accept[capabilities0-confirm-True] webdriver/tests/get_element_rect/user_prompts.py::test_accept[capabilities0-prompt-] webdriver/tests/get_element_rect/user_prompts.py::test_dismiss[capabilities0-alert-None] webdriver/tests/get_element_rect/user_prompts.py::test_dismiss[capabilities0-confirm-False] webdriver/tests/get_element_rect/user_prompts.py::test_dismiss[capabilities0-prompt-None]

Attachments
Add attachment proposed patch, testcase, etc.

Patrick Angle

Comment 1 2022-11-30 13:57:43 PST

<rdar://100588620>

Patrick Angle

Comment 2 2022-11-30 14:32:32 PST

Pull request: https://github.com/WebKit/WebKit/pull/6991

EWS

Comment 3 2022-12-07 12:04:16 PST

Committed 257498@main (ac88ff2a875c): <https://commits.webkit.org/257498@main> Reviewed commits have been landed. Closing PR #6991 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.