Bug 248552

Summary:

AX: Make accessibility/mac/input-slider.html await dynamic page changes so it can pass in ITM

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Tyler Wilcock 2022-11-30 13:31:01 PST

AX: Make accessibility/mac/input-slider.html await dynamic page changes so it can pass in ITM

Comment 1 Radar WebKit Bug Importer 2022-11-30 13:31:15 PST

<rdar://problem/102827179>

Comment 2 Tyler Wilcock 2022-11-30 13:35:03 PST

Created attachment 463815 [details]
Patch

Comment 3 Andres Gonzalez 2022-12-01 07:28:57 PST

(In reply to Tyler Wilcock from comment #2)
> Created attachment 463815 [details]
> Patch

+    var slider = document.getElementById("slider");
+    var sliderAXObject = accessibilityController.accessibleElementById("slider");

In cases like this, can we just call the AX object variable like axSlider? i.e., the DOM element foo and the AX object axFoo.

Comment 4 EWS 2022-12-02 11:49:10 PST

Committed 257297@main (75825c6ed268): <https://commits.webkit.org/257297@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463815 [details].

Comment 5 Tyler Wilcock 2022-12-03 01:48:10 PST

(In reply to Andres Gonzalez from comment #3)
> (In reply to Tyler Wilcock from comment #2)
> > Created attachment 463815 [details]
> > Patch
> 
> +    var slider = document.getElementById("slider");
> +    var sliderAXObject =
> accessibilityController.accessibleElementById("slider");
> 
> In cases like this, can we just call the AX object variable like axSlider?
> i.e., the DOM element foo and the AX object axFoo.
Oops, forgot to respond to this. Definitely agree — sliderAXObject was the name in the  existing version of the test, but will follow this naming scheme for future patches.