Bug 248525

Summary:	Meta tag for Tests with Empty & Single Empty Line Expectation Files
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	aakash_jain, ap, bfulgham, jbedard, ryanhaddad
Priority:	P2
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	248037

Description Ahmad Saleem 2022-11-30 04:11:36 PST

Hi Team,

Just a suggestion and it can be ignored, just to avoid clutter on GitHub by having empty files or blank files with single line as a result of "test cases", why not we have special header:

<meta name="empty-test-file-expectation" />

So when those test run, EWS will know that the empty file is to be generated for this and rather than comparing with empty files (cluttering Webkit GitHub), it can be just done automatically within the tool.

It will help us delete at least few empty or blank expectation files and make repo cleaner.

Just wanted to raise this as feature / enhancement request of test infrastructure.

Thanks!

Comment 1 Alexey Proskuryakov 2022-11-30 11:36:23 PST

I don't think that we should do this. Having a second way to declare expectations will be forever confusing to engineers, and will complicate webkitpy code. It's better to only have one place to look at than multiple.

We do have a similar feature for test options, and the experience of having it is not great. The reason why we still have it is that there isn't an alternative way to set these test options. Notably, it's not using a <meta>, but custom syntax, because run-webkit-tests doesn't understand HTML.