Bug 248517

Summary:	REGRESSION(257006@main): [BigSur+ wk1 EWS] many imported/w3c/web-platform-tests/geolocation-API (layout-tests) are constant text failures
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	New Bugs	Assignee:	Marcos Caceres <marcosc>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	marcosc, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Robert Jenner 2022-11-29 22:07:39 PST

The following imported/w3c/web-platform-tests/geolocation-API (layout-tests) are constant text failures on wk1 BigSur and higher as well as on EWS:

imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html
imported/w3c/web-platform-tests/geolocation-API/permission.https.html


HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fgeolocation-API%2FPositionOptions.https.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fgeolocation-API%2Fpermission.https.html


TEXT DIFF FOR "imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html":
 PASS Call getCurrentPosition with wrong type for enableHighAccuracy. No exception expected.
 PASS Call watchPosition with wrong type for enableHighAccuracy. No exception expected.
 PASS Set timeout and maximumAge to 0, check that timeout error raised (getCurrentPosition)
-PASS Set timeout and maximumAge to 0, check that timeout error raised (watchPosition)
+FAIL Set timeout and maximumAge to 0, check that timeout error raised (watchPosition) promise_test: Unhandled rejection with value: object "[object GeolocationPosition]"
 PASS Check that a negative timeout and maxAge values are clamped to 0 (getCurrentPosition)
-PASS Check that a negative timeout and maxAge values are clamped to 0 (watchPosition)
+FAIL Check that a negative timeout and maxAge values are clamped to 0 (watchPosition) promise_test: Unhandled rejection with value: object "[object GeolocationPosition]"
 

TEXT DIFF FOR "imported/w3c/web-platform-tests/geolocation-API/permission.https.html"
-PASS Query "geolocation" powerful feature
+FAIL Query "geolocation" powerful feature promise_test: Unhandled rejection with value: object "NotSupportedError: Permissions::query does not support this API"

Comment 1 Robert Jenner 2022-11-29 22:25:02 PST

I was able to reproduce the failures at Ventura Production ToT running the test as follows 


run-webkit-tests <insert_test_name_here> -1

I have also determined that https://commits.webkit.org/257006@main is the regression point. It was a Resync of tests from upstream. It introduced:

"imported/w3c/web-platform-tests/geolocation-API/permission.https.html" which started failing on Mac wk1 from the get go, and it also looks like it caused "imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html" to constantly fail on wk1.

Comment 2 Radar WebKit Bug Importer 2022-11-29 22:25:21 PST

<rdar://problem/102798964>

Comment 3 EWS 2022-11-29 22:38:12 PST

Test gardening commit 257167@main (a533c8ef0151): <https://commits.webkit.org/257167@main>

Reviewed commits have been landed. Closing PR #6958 and removing active labels.

Comment 4 Marcos Caceres 2022-12-04 20:38:40 PST

Pull request: https://github.com/WebKit/WebKit/pull/7139

Comment 5 Marcos Caceres 2022-12-06 06:31:30 PST

Pull request: https://github.com/WebKit/WebKit/pull/7197

Comment 6 Marcos Caceres 2022-12-06 08:41:24 PST

Pull request: https://github.com/WebKit/WebKit/pull/7206

Comment 7 Marcos Caceres 2022-12-06 08:48:26 PST

Pull request: https://github.com/WebKit/WebKit/pull/7207

Comment 8 Marcos Caceres 2022-12-06 16:45:13 PST

Pull request: https://github.com/WebKit/WebKit/pull/7231

Comment 9 EWS 2022-12-07 14:09:33 PST

Committed 257508@main (c262bad7da23): <https://commits.webkit.org/257508@main>

Reviewed commits have been landed. Closing PR #7231 and removing active labels.