Bug 248502

Summary: Manually invalidate the FontCache before clearing ThreadGlobalData.
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: Layout and RenderingAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Matt Woodrow
Reported 2022-11-29 15:34:17 PST
Destructing the FontCache can recurse back into the ThreadGlobalData getter (to remove cached entries), so we want to manually clear the FontCache before clearing the ThreadGlobalData pointer. This also moves m_destroyed to earlier in the class, so it's guaranteed to be destructed after m_fontCache.
Attachments
Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2022-11-29 15:39:32 PST
Pull request: https://github.com/WebKit/WebKit/pull/6948
EWS
Comment 2 2022-11-29 20:57:39 PST
Committed 257160@main (2d8a9204f770): <https://commits.webkit.org/257160@main> Reviewed commits have been landed. Closing PR #6948 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.