Bug 248482

Summary:

AX: add to AXLogger the ability to filter the output by keywords.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Andres Gonzalez 2022-11-29 11:12:19 PST

At the moment you get either all or none, you can only filter by thread.

Comment 1 Radar WebKit Bug Importer 2022-11-29 11:12:33 PST

<rdar://problem/102775230>

Comment 2 Andres Gonzalez 2022-11-29 11:18:51 PST

Created attachment 463791 [details]
Patch

Comment 3 Andres Gonzalez 2022-11-29 12:48:59 PST

Created attachment 463793 [details]
Patch

Comment 4 chris fleizach 2022-11-30 13:56:57 PST

Comment on attachment 463793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463793&action=review

> Source/WebCore/accessibility/AXLogger.cpp:59
> +        auto it = std::find_if(nameFilter->begin(), nameFilter->end(), [this] (const auto& name) {

can you choose a more descriptive variable name (instead of 'it')

Comment 5 EWS 2022-11-30 18:40:12 PST

Committed 257212@main (d6d9cf06a048): <https://commits.webkit.org/257212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463793 [details].