Bug 248479
| Summary: | Allow _target argument to shouldBeCloseTo to be a string to eval | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across this to update 'js-test.js' to make it more error proof.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/14fd02d3d15e26cfccf048e175ab4b0e7e928b43%5E%21/#F0
I just wanted to raise this bug to get opinion whether it is worth merging or not.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Seems like a nice improvement in principle. Two comments:
- We have more than one copy of shouldBeCloseTo(), would want to update them all.
- The change in itself doesn't change anything observable, so it's largely pointless unless some tests take advantage of the new functionality.
Radar WebKit Bug Importer
<rdar://problem/103141617>