Bug 248450

Summary:	Fix CSS.supports behaviour with regards to !important and whitepace
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, commit-queue, darin, ntim, rackler, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	248634
Bug Blocks:

Description Ahmad Saleem 2022-11-28 17:44:57 PST

Hi Team,

Just another bug report based on Blink's comment and our failing test cases:

Failing Test Case - https://jsfiddle.net/wvsu7koh/show

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/36890765b05b48d8065737682b4e878645b601b2

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/f3dfd0cc716eec21249cf1b3544fff9303053a0a/Source/WebCore/css/DOMCSSNamespace.cpp#L45

Just wanted to raise bug for future purposes. Thanks!

Comment 1 Sam Sneddon [:gsnedders] 2022-11-29 15:30:56 PST

To note, this is specifically CSS.supports (i.e., the JS-exposed API) and not @supports.

Comment 2 Ahmad Saleem 2022-11-30 03:56:44 PST

https://github.com/WebKit/WebKit/pull/6949

Comment 3 EWS 2022-11-30 13:46:54 PST

Committed 257196@main (4b4a31ba7117): <https://commits.webkit.org/257196@main>

Reviewed commits have been landed. Closing PR #6949 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2022-11-30 13:47:18 PST

<rdar://problem/102827775>

Comment 5 Darin Adler 2022-12-01 15:24:14 PST

I believe that the test imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks.html has been crashing in debug builds since this change landed.

Comment 6 WebKit Commit Bot 2022-12-01 15:39:03 PST

Re-opened since this is blocked by bug 248634

Comment 7 Ahmad Saleem 2022-12-02 02:26:47 PST

https://github.com/WebKit/WebKit/pull/7068

Comment 8 EWS 2022-12-02 05:28:39 PST

Committed 257280@main (9d5c6857a50c): <https://commits.webkit.org/257280@main>

Reviewed commits have been landed. Closing PR #7068 and removing active labels.

Comment 9 Karl Rackler 2022-12-02 08:17:50 PST

Reverted by https://github.com/WebKit/WebKit/pull/7071

Comment 10 EWS 2022-12-02 08:20:21 PST

Committed 257286@main (3401a13c6836): <https://commits.webkit.org/257286@main>

Reviewed commits have been landed. Closing PR #7071 and removing active labels.

Comment 11 Karl Rackler 2022-12-02 08:23:57 PST

Revert because it broke the build for the bots

Comment 12 Ahmad Saleem 2022-12-02 15:42:49 PST

Third Time Charm - https://github.com/WebKit/WebKit/pull/7100

Comment 13 EWS 2022-12-02 18:36:03 PST

Committed 257313@main (30880fe8446d): <https://commits.webkit.org/257313@main>

Reviewed commits have been landed. Closing PR #7100 and removing active labels.