Bug 248449

Summary: REGRESSION(257041@main): [ macOS ] 2X transitions/ (Layout-Tests are constant timeouts
Product: WebKit Reporter: Robert Jenner <jenner>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: obrufau, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Robert Jenner 2022-11-28 17:35:52 PST 
The following two transitions/ (Layout-tests) are constant timeouts on macOS starting at 257041@main:
transitions/shorthand-transitions.html 
transitions/border-radius-transition.html 


HISTORY:
https://results.webkit.org/?platform=mac&suite=layout-tests&suite=layout-tests&test=transitions%2Fborder-radius-transition.html&test=transitions%2Fshorthand-transitions.html
Comment 1 Radar WebKit Bug Importer 2022-11-28 17:36:25 PST 
<rdar://problem/102742539>
Comment 2 Robert Jenner 2022-11-28 17:40:19 PST 
I was able to reproduce the timeouts at Ventura Debug ToT running the test as follows:


run-webkit-tests <insert_test_here>
Comment 3 EWS 2022-11-28 17:55:18 PST 
Test gardening commit 257098@main (e9b769950822): <https://commits.webkit.org/257098@main>

Reviewed commits have been landed. Closing PR #6902 and removing active labels.
Comment 4 Robert Jenner 2022-11-28 17:56:38 PST 
I tried running the tests with the --no-timeout flag as well. After 10 minutes each the tests never ran. So these do appear to be legit timeouts, and not just slow tests.

So I've added [ Timeout ] to the test's expectations at the commit above.  


It should also be noted that both of these tests were failing before 257041@main. There is just an expectation marked as [ Pass Failure ]
Comment 5 Robert Jenner 2022-11-28 17:57:38 PST 
Starting on Oriol who committed the change that caused these two tests to constantly timeout.
Comment 6 Oriol Brufau 2022-11-28 17:59:09 PST 
Ah, that's because I made getComputedStyle().getPropertyCSSValue() consistently return a CSSValuePair, which throws when transition-test-helpers.js attempts to use getFloatValue().

The solution seems to use getPropertyValue() instead.

Also adding a try..catch seems a good idea.
Comment 7 Oriol Brufau 2022-11-29 08:28:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6915
Comment 8 EWS 2022-11-30 17:25:39 PST 
Committed 257208@main (4ee897dd423c): <https://commits.webkit.org/257208@main>

Reviewed commits have been landed. Closing PR #6915 and removing active labels.
Comment 9 Simon Fraser (smfr) 2022-11-30 17:38:05 PST 
There's equivalent code in LayoutTests/animations/animation-test-helpers.js (sadly)