Bug 248439

Summary: Remove Document.getOverrideStyle()
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, karlcow, ntim, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2022-11-28 16:02:43 PST
Hi Team,

While going through Blink's fixes, I came across another clean-up patch, which Blink dropped support in 2015:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/c4295e1eb8e409eb724af535fdce94ecdc10654d

Webkit Still has references to it:

https://github.com/WebKit/WebKit/blob/b9824fc290ac9247e8a04f38632a8fdd4b9ec02d/Source/WebCore/dom/Document.idl#L93 & https://github.com/WebKit/WebKit/blob/b9824fc290ac9247e8a04f38632a8fdd4b9ec02d/Source/WebCore/dom/Document.h#LL947

I think it would be good clean-up to remove this non-standard feature now.

Thanks!
Comment 1 Ryosuke Niwa 2022-12-01 16:40:10 PST
Pull request: https://github.com/WebKit/WebKit/pull/7056
Comment 2 EWS 2022-12-02 23:04:47 PST
Committed 257318@main (62957ecdf469): <https://commits.webkit.org/257318@main>

Reviewed commits have been landed. Closing PR #7056 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-02 23:05:19 PST
<rdar://problem/102930684>