Bug 248435

Summary: Horizontal table border bug
Product: WebKit Reporter: nicholas.kang
Component: TablesAssignee: alan <zalan>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Critical CC: ap, zalan
Priority: P2    
Version: Safari 15   
Hardware: Mac (Apple Silicon)   
OS: iOS 15   
Attachments:
Description Flags
Horizontal Border Misalignment Across Row
none
Horizontal border issue
none
Screenshot (ToT) none

nicholas.kang
Reported 2022-11-28 15:49:23 PST
Created attachment 463771 [details] Horizontal Border Misalignment Across Row Beginning around September 2022, a very odd bug is visible on our tables. Horizontal table borders are not lining up, some would go higher or lower across a row. Some table cells would also get larger bottom borders across rows. Odd/extra spacing between rows of tables, where tables have a background color and border bottom is applied to td's.
Attachments
Horizontal Border Misalignment Across Row (491.40 KB, image/png)
2022-11-28 15:49 PST, nicholas.kang 		no flags
Details
Horizontal border issue (142.90 KB, image/png)
2022-11-29 16:57 PST, nicholas.kang 		no flags
Details
Screenshot (ToT) (190.11 KB, image/png)
2022-11-29 17:16 PST, alan 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-11-28 19:07:41 PST
> Beginning around September 2022 Could you please clarify what caused a change in September? Is this due to a new Safari version, or something else?
alan
Comment 2 2022-11-28 20:05:12 PST
(In reply to Alexey Proskuryakov from comment #1) > > Beginning around September 2022 > > Could you please clarify what caused a change in September? Is this due to a > new Safari version, or something else? Also, could you provide a test case with the broken behavior (or a link to a publicly accessible page where the bug shows). Thanks.
nicholas.kang
Comment 3 2022-11-29 16:55:26 PST
We discovered something that may help triangulate the cause of this issue. While we simply started noticing the issue in September, we are actually able to reproduce the issue when viewing our tables on Retina screens. If you view the fourth to last table (labeled Higher density NewTable with multiple components ) at this site (https://ink.carta.com/expose/index.html#newtable), you should see the horizontal border issue in the cells.
nicholas.kang
Comment 4 2022-11-29 16:57:32 PST
Created attachment 463796 [details] Horizontal border issue Please reproduce this on a Retina screen/monitor. https://ink.carta.com/expose/index.html#newtable Higher density NewTable with multiple components
alan
Comment 5 2022-11-29 17:05:47 PST
Thank you. I am able to reproduce it.
alan
Comment 6 2022-11-29 17:16:35 PST
Created attachment 463798 [details] Screenshot (ToT) this seems to have progressed on trunk (tip of tree) -see the attached screenshot. let me find the progression point.
alan
Comment 8 2022-11-30 09:01:34 PST
(In reply to zalan from comment #7) > progression range: > https://github.com/WebKit/WebKit/compare/ > 52eab19e06842e724b2000490ca673a0bd4dbca8... > a8f81aab31317cd32026b3f895f309e02bc9089f > > https://github.com/WebKit/WebKit/commit/ > d0364ca6972512ac0304c51b369baa3c11f37651 is a strong candidate. actually it's https://commits.webkit.org/255063@main
alan
Comment 9 2022-11-30 09:04:29 PST
fixed by 255063@main
nicholas.kang
Comment 10 2022-12-02 10:21:48 PST
When can we expect for this fix to go out to prod?
nicholas.kang
Comment 11 2022-12-05 10:07:02 PST
I see that the status has been changed to resolved, but we are still seeing the issue on our end.
alan
Comment 12 2022-12-06 20:55:54 PST
(In reply to nicholas.kang from comment #11) > I see that the status has been changed to resolved, but we are still seeing > the issue on our end. Yes, this fix has not been shipped yet (resolved, in this context simply means that the bug has been landed on trunk WebKit)
alan
Comment 13 2022-12-06 20:56:49 PST
(In reply to zalan from comment #12) > (In reply to nicholas.kang from comment #11) > > I see that the status has been changed to resolved, but we are still seeing > > the issue on our end. > Yes, this fix has not been shipped yet (resolved, in this context simply > means that the bug has been landed on trunk WebKit) Yes, this fix has not been shipped yet in Safari (other products may have picked it up already).
Note You need to log in before you can comment on or make changes to this bug.