| Summary: | [MQ4] Disallow negative values | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, ntim, philipj, sergio, webkit-bug-importer, youssefdevelops, y_soliman, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 248391 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2022-11-28 07:33:54 PST
Created attachment 463761 [details]
Patch
(Fwiw I think the main reason they're allowed is for calc()) (In reply to Tim Nguyen (:ntim) from comment #2) > (Fwiw I think the main reason they're allowed is for calc()) They are still allowed for calc() (matching others). Created attachment 463764 [details]
Patch
Not sure I feel about using { } instead of std::nullopt for std::optional return values.
(In reply to Darin Adler from comment #6) > Not sure I feel about using { } instead of std::nullopt for std::optional > return values. It is a pretty common pattern in WebKit. I don't see the benefits of being more verbose. (In reply to Antti Koivisto from comment #7) > It is a pretty common pattern in WebKit. I don't see the benefits of being > more verbose. OK, agreed. Committed 257105@main (aacea0b8da7d): <https://commits.webkit.org/257105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463764 [details]. |