Bug 248367

Summary:	compositionstart event's data should contain text to replace
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	UI Events	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	karlcow, rniwa
Priority:	P2
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=118684

Description Ahmad Saleem 2022-11-26 17:15:25 PST

Hi Team,

I was going through Blink commits and found another case, which can be merged:

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b336a53b180ca88e40fef99e7f0a0779bd3d5986/Source/WebCore/editing/Editor.cpp#L2161

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=153319

Just wanted to raise this bug before trying to do PR.

Thanks!

Comment 1 Karl Dubost 2022-11-27 18:53:37 PST

This was done in Bug 118684 by Ryosuke in July 2013!
> "to match IE and Firefox behaviors"

So why it's not here anymore. 

Ah Ryosuke is mentioning that his patch was simpler by just calling `selectedText()`
https://chromiumcodereview.appspot.com/18041002#msg10


selectedText() was later renamed as originalText
https://github.com/WebKit/WebKit/commit/c824bf1ebb4be32e85df6256fe0619a22a637019#diff-298ab5f43228bb977d82fadbd60cad9a87bb25aa0e3eabdb77779a8455136d0bR1872-R1883

Adding Ryosuke, to know if this change is really necessary.

Comment 2 Ahmad Saleem 2022-11-28 05:02:07 PST

Marking as Duplicate - since Blink commit was same. So no need to do it again. Thanks!

*** This bug has been marked as a duplicate of bug 118684 ***