Bug 248361

Summary:

Potential Crash fix by not allowing editing to remove PseudoElements

Product:

WebKit

Reporter:

Ahmad Saleem <ahmad.saleem792>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

rniwa

Priority:

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case	none

Description Ahmad Saleem 2022-11-26 07:23:40 PST

Hi Team,

While going through Blink commits, I came across another potential crash fix, which can be applied:

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=166985

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/f0e70ac5078d742d598da042f4728d042aca3e98/Source/WebCore/dom/ContainerNode.cpp#LL659 & for PseudoElement.cpp, there might be case to add new function.

Just wanted to raise to confirm whether we need to merge this or not.

Thanks!

Comment 1 Ryosuke Niwa 2022-11-28 12:11:44 PST

Created attachment 463767 [details]
Test case

Comment 2 Ryosuke Niwa 2022-11-28 12:12:08 PST

The test doesn't reproduce a crash in WebKit.