Bug 248343

Summary: REGRESSION(256830@main): Fix WebRTC cmake build after usrsctp removal
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebRTCAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, philn, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=246136
Attachments:
Description Flags
Mac platform changes none

Olivier Blin
Reported 2022-11-25 07:58:02 PST
In 256830@main, the usrsctp third party has been removed from WebRTC, but the cmake files have not been updated. This was ok in the first pull request: https://github.com/WebKit/WebKit/pull/5070 But it has been missed in the second one: https://github.com/WebKit/WebKit/pull/6584
Attachments
Mac platform changes (4.16 KB, patch)
2022-11-28 05:52 PST, Olivier Blin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2022-11-25 07:59:33 PST
Pull request: https://github.com/WebKit/WebKit/pull/6816
Philippe Normand
Comment 2 2022-11-27 02:33:11 PST
*** This bug has been marked as a duplicate of bug 248336 ***
Olivier Blin
Comment 3 2022-11-28 05:52:50 PST
Created attachment 463754 [details] Mac platform changes I guess the Mac platform still needs the PlatformMac.cmake change. Should I reopen the bug just to fix this one and remove the WEBRTC_HAVE_USRSCTP define? Attached is what remains from my patch.
Philippe Normand
Comment 4 2022-11-28 05:56:25 PST
Ah yes, please submit a new PR, I'm reopening this bug :)
Olivier Blin
Comment 5 2022-11-30 14:14:27 PST
Pull request: https://github.com/WebKit/WebKit/pull/6988
EWS
Comment 6 2022-12-09 10:45:35 PST
Committed 257637@main (a0968d750159): <https://commits.webkit.org/257637@main> Reviewed commits have been landed. Closing PR #6988 and removing active labels.
Radar WebKit Bug Importer
Comment 7 2022-12-09 10:46:19 PST
<rdar://problem/103186359>
Note You need to log in before you can comment on or make changes to this bug.