Bug 248243

Summary:	REGRESSION(256902@main): [WPE] Broke context-menu signal
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	WPE WebKit	Assignee:	Michael Catanzaro <mcatanzaro>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	PC
OS:	Linux

Michael Catanzaro

Reported 2022-11-22 12:49:00 PST

When reviewing 256902@main "[GTK][WPE] Move WebKitWebView::context-menu signal declaration to platform specific files" I missed that it broke the context-menu signal for WPE. The signal declaration now always has two parameters, but it is always emitted with three parameters. Oops. The expected behavior is two parameters for new API, three parameters for old API.

Attachments
Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2022-11-22 14:30:29 PST

Pull request: https://github.com/WebKit/WebKit/pull/6745

EWS

Comment 2 2022-11-24 07:57:37 PST

Committed 256991@main (4b24459ebb4a): <https://commits.webkit.org/256991@main> Reviewed commits have been landed. Closing PR #6745 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.