Bug 248196

Summary: [LFC][Integration] Cleanup LayoutIntegrationCoverage::canUseForChild
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

alan
Reported 2022-11-21 17:17:57 PST
ssia
Attachments
Patch (2.96 KB, patch)
2022-11-21 17:43 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2022-11-21 20:08 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (3.25 KB, patch)
2022-11-21 21:31 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-11-21 17:43:18 PST
Created attachment 463647 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-11-21 18:07:47 PST
Comment on attachment 463647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463647&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406 > SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons); I think you meant ChildBoxIsFloatingOrPositioned ?
alan
Comment 3 2022-11-21 18:27:28 PST
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 463647 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463647&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406 > > SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons); > > I think you meant ChildBoxIsFloatingOrPositioned ? oops. thanks.
alan
Comment 4 2022-11-21 20:08:13 PST
Created attachment 463651 [details] Patch
alan
Comment 5 2022-11-21 21:31:01 PST
Created attachment 463658 [details] [fast-cq]Patch
EWS
Comment 6 2022-11-22 06:22:53 PST
Committed 256933@main (b10a458bea0e): <https://commits.webkit.org/256933@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463658 [details].
Radar WebKit Bug Importer
Comment 7 2022-11-22 06:23:16 PST
<rdar://problem/102605367>
Note You need to log in before you can comment on or make changes to this bug.