Bug 248196

Summary: [LFC][Integration] Cleanup LayoutIntegrationCoverage::canUseForChild
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

Description zalan 2022-11-21 17:17:57 PST
ssia
Comment 1 zalan 2022-11-21 17:43:18 PST
Created attachment 463647 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-11-21 18:07:47 PST
Comment on attachment 463647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463647&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406
>              SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons);

I think you meant ChildBoxIsFloatingOrPositioned ?
Comment 3 zalan 2022-11-21 18:27:28 PST
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 463647 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463647&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:406
> >              SET_REASON_AND_RETURN_IF_NEEDED(FlowIsUnsupportedListItem, reasons, includeReasons);
> 
> I think you meant ChildBoxIsFloatingOrPositioned ?
oops. thanks.
Comment 4 zalan 2022-11-21 20:08:13 PST
Created attachment 463651 [details]
Patch
Comment 5 zalan 2022-11-21 21:31:01 PST
Created attachment 463658 [details]
[fast-cq]Patch
Comment 6 EWS 2022-11-22 06:22:53 PST
Committed 256933@main (b10a458bea0e): <https://commits.webkit.org/256933@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463658 [details].
Comment 7 Radar WebKit Bug Importer 2022-11-22 06:23:16 PST
<rdar://problem/102605367>