Bug 248195

Summary:	Allow `auto` and `normal` as container-name
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Karl Dubost <karlcow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	karlcow, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, GoodFirstBug, InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Tim Nguyen (:ntim) 2022-11-21 17:11:39 PST

https://wpt.fyi/results/css/css-contain/container-queries/container-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop
https://wpt.fyi/results/css/css-contain/container-queries/at-container-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop
https://wpt.fyi/results/css/css-contain/container-queries/container-name-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned&view=interop

Comment 1 Radar WebKit Bug Importer 2022-11-21 17:11:48 PST

<rdar://problem/102591474>

Comment 2 Karl Dubost 2022-11-27 19:43:59 PST

for my own education.

https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#4654-4669
https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/Source/WebCore/css/ContainerQueryParser.cpp#54-74

Does that it needs another function to parse a specific case.

Comment 3 Tim Nguyen (:ntim) 2022-11-27 22:42:32 PST

(In reply to Karl Dubost from comment #2)
> for my own education.
> 
> https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/
> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp#4654-4669
> https://searchfox.org/wubkat/rev/fd9594cdf418745718908fd1869a116307a46e7a/
> Source/WebCore/css/ContainerQueryParser.cpp#54-74
> 
> Does that it needs another function to parse a specific case.

consumeContainerQuery takes care of consuming the at-rule.

consumeSingleContainerName takes care of consuming the name in the at-rule, but also in the `container-name` CSS property (see consumeContainerName).

Comment 4 Karl Dubost 2022-11-28 04:47:17 PST

Pull request: https://github.com/WebKit/WebKit/pull/6855

Comment 5 EWS 2022-12-01 07:45:52 PST

Committed 257236@main (f494a4e0965b): <https://commits.webkit.org/257236@main>

Reviewed commits have been landed. Closing PR #6855 and removing active labels.