Bug 248173
| Summary: | Workers: Simplify early dedicated worker termination | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I found another simplification in workers termination, which can be brought to Webkit:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=180532
Although there is no test case to confirm whether Webkit suffer from some issue due to it or not but since it is just simplification, it seems to be safe. I can do draft PR and run via EWS to see if there is any issue across multiple platforms.
https://github.com/WebKit/WebKit/blob/a845b7e4ec0490d1d8f5d7e7f5ddf44fef0b6f17/Source/WebCore/workers/WorkerMessagingProxy.cpp#L330
^ Remove this bit from here and move it here:
https://github.com/WebKit/WebKit/blob/a845b7e4ec0490d1d8f5d7e7f5ddf44fef0b6f17/Source/WebCore/workers/WorkerMessagingProxy.cpp#LL122
Just wanted to raise bug.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 256949@main (0987e578a6a8): <https://commits.webkit.org/256949@main>
Reviewed commits have been landed. Closing PR #6700 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102612212>