| Summary: |
[web-animations] keyframes should be recomputed if used CSS variable changes |
| Product: |
WebKit
|
Reporter: |
Antoine Quint <graouts> |
| Component: |
Animations | Assignee: |
Antoine Quint <graouts> |
| Status: |
RESOLVED
FIXED
|
|
|
| Severity: |
Normal
|
CC: |
dino, graouts, koivisto, simon.fraser, webkit-bug-importer
|
| Priority: |
P2
|
Keywords: |
InRadar, WebExposed, WPTImpact |
| Version: |
Safari Technology Preview | |
|
| Hardware: |
Unspecified | |
|
| OS: |
Unspecified | |
|
| See Also: |
https://github.com/web-platform-tests/wpt/pull/37043
https://bugs.webkit.org/show_bug.cgi?id=201736
|
We're failing a couple of tests in web-animations/animation-model/keyframe-effects/effect-value-context-filling.html because we fail to update keyframes when a used CSS variable changes. For instance: test(t => { const div = createDiv(t); div.style.setProperty('--target', '100px'); const animation = div.animate( [{ marginLeft: '0px' }, { marginLeft: 'var(--target)' }], { duration: 1000, fill: 'forwards' } ); animation.finish(); assert_equals( getComputedStyle(div).marginLeft, '100px', 'Effect value before updating variable' ); div.style.setProperty('--target', '200px'); assert_equals( getComputedStyle(div).marginLeft, '200px', 'Effect value after updating variable' ); }, 'Filling effect values reflect changes to variables on element'); In fact, after fixing bug 186490, the last two remaining failures in that test are due to this issue.