Bug 248127

Summary: Cleanup StyleProperties::fontSynthesisValue()
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Tim Nguyen (:ntim)
Reported 2022-11-19 02:29:43 PST
- Use `propertyAsValueID` instead of custom lambda, it is possible since longhands are never added implicitly. - Always do checks against the value ID (it is now possible now that we include the `isCSSWideKeyword()` function) - Use pattern consistent with other methods for appending the strings to the string builder.
Attachments
Radar WebKit Bug Importer
Comment 1 2022-11-19 02:30:03 PST
Tim Nguyen (:ntim)
Comment 2 2022-11-19 02:32:08 PST
EWS
Comment 3 2022-11-19 10:45:37 PST
Committed 256877@main (55fafd865860): <https://commits.webkit.org/256877@main> Reviewed commits have been landed. Closing PR #6670 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.