Bug 248108

Summary:

AX: Dynamic aria-disabled changes don't update AXPropertyName::IsEnabled for descendants

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, Hironori.Fujii, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Tyler Wilcock 2022-11-18 16:06:33 PST

https://w3c.github.io/aria/#aria-disabled

> The state of being disabled applies to the element with aria-disabled and all focusable descendant elements of the element on which the aria-disabled attribute is applied.

Comment 1 Radar WebKit Bug Importer 2022-11-18 16:06:43 PST

<rdar://problem/102534000>

Comment 2 Tyler Wilcock 2022-11-18 16:12:27 PST

Created attachment 463616 [details]
Patch

Comment 3 chris fleizach 2022-11-27 23:05:35 PST

Comment on attachment 463616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463616&action=review

> COMMIT_MESSAGE:9
> +its descendants, too. This is required becaues aria-disabled also

because

Comment 4 Tyler Wilcock 2022-11-28 10:13:44 PST

Created attachment 463763 [details]
Patch

Comment 5 EWS 2022-11-29 20:51:50 PST

Committed 257159@main (e113b29b327f): <https://commits.webkit.org/257159@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463763 [details].

Comment 6 Fujii Hironori 2023-01-10 22:34:06 PST

Comment on attachment 463763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463763&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:414
> +    AXLOG(makeString("Updating properties ", properties, " for objectID ", axObject.objectID().loggingString()));

Does this code generate an expected log string for `properties`?

Comment 7 Tyler Wilcock 2023-01-10 22:45:55 PST

(In reply to Fujii Hironori from comment #6)
> Comment on attachment 463763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463763&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:414
> > +    AXLOG(makeString("Updating properties ", properties, " for objectID ", axObject.objectID().loggingString()));
> 
> Does this code generate an expected log string for `properties`?
Nope. Noticed that but haven't got around to fixing it yet.