Bug 248096
| Summary: | Store replaced element aspect ratio dimensions in its own data structure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
Replaced elements are currently computing their aspect ratio fairly deep into the call stack and then propagating the computed double back up. This has been introducing some slight precision issues when working with replaced elements and their aspect ratio. Instead the dimensions associated with the ratio should be stored in their own struct and then propagated back up the computeIntrinsicRatioInformation stack. The caller can then decide how they want to use the ratio (compute into a double or use individual dimensions).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102525236>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/6645
EWS
Committed 257430@main (90b0d80278b2): <https://commits.webkit.org/257430@main>
Reviewed commits have been landed. Closing PR #6645 and removing active labels.