Bug 248093

Summary:	REGRESSION (256812@main): [macOS] ASSERTION FAILED: m_element in WebKit::WebFullScreenManager::setAnimatingFullScreen()
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	jenner, jer.noble, ntim, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=247991 https://bugs.webkit.org/show_bug.cgi?id=248734

Description Ryan Haddad 2022-11-18 10:46:17 PST

The following 3 API tests are asserting after https://commits.webkit.org/256812@main

TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen
TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen
TestWebKitAPI.Fullscreen.Focus

        ASSERTION FAILED: m_element
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp(327) : void WebKit::WebFullScreenManager::setAnimatingFullScreen(bool)
        1   0x1432e9064 WTFCrash
        2   0x12e5fd6c0 std::__1::optional<unsigned long long>::optional<unsigned long long, 0>(unsigned long long&&)
        3   0x13035f954 WebKit::WebFullScreenManager::setAnimatingFullScreen(bool)
        4   0x130b4aea8 void IPC::callMemberFunctionImpl<WebKit::WebFullScreenManager, void (WebKit::WebFullScreenManager::*)(bool), std::__1::tuple<bool>, 0ul>(WebKit::WebFullScreenManager*, void (WebKit::WebFullScreenManager::*)(bool), std::__1::tuple<bool>&&, std::__1::integer_sequence<unsigned long, 0ul>)
        5   0x130b4ad60 void IPC::callMemberFunction<WebKit::WebFullScreenManager, void (WebKit::WebFullScreenManager::*)(bool), std::__1::tuple<bool>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<bool>&&, WebKit::WebFullScreenManager*, void (WebKit::WebFullScreenManager::*)(bool))
        6   0x130b49b08 void IPC::handleMessage<Messages::WebFullScreenManager::SetAnimatingFullScreen, WebKit::WebFullScreenManager, void (WebKit::WebFullScreenManager::*)(bool)>(IPC::Connection&, IPC::Decoder&, WebKit::WebFullScreenManager*, void (WebKit::WebFullScreenManager::*)(bool))
        7   0x130b492dc WebKit::WebFullScreenManager::didReceiveWebFullScreenManagerMessage(IPC::Connection&, IPC::Decoder&)
        8   0x13035e110 WebKit::WebFullScreenManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        9   0x130bbe210 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        10  0x1311f36f4 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
        11  0x1302daf3c WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
        12  0x1311c3d88 IPC::Connection::dispatchMessage(IPC::Decoder&)
        13  0x1311c418c IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
        14  0x1311c4504 IPC::Connection::dispatchOneIncomingMessage()
        15  0x1311e8b2c IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_17::operator()() const
        16  0x1311e8a60 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_17, void>::call()
        17  0x143316048 WTF::Function<void ()>::operator()() const
        18  0x1433b23c8 WTF::RunLoop::performWork()
        19  0x1433b80b8 WTF::RunLoop::performWork(void*)
        20  0x1a600a9a0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
        21  0x1a600a8ec __CFRunLoopDoSource0
        22  0x1a600a5ec __CFRunLoopDoSources0
        23  0x1a6008f6c __CFRunLoopRun
        24  0x1a6008490 CFRunLoopRunSpecific
        25  0x1a6ee5210 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
        26  0x1a6f75604 -[NSRunLoop(NSRunLoop) run]
        27  0x1a5c7f8b4 _xpc_objc_main
        28  0x1a5c7f1d0 xpc_main
        29  0x12f04fe40 WebKit::XPCServiceMain(int, char const**)
        30  0x13116d348 WKXPCServiceMain
        31  0x104267f3c main

https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen&test=TestWebKitAPI.Fullscreen.Focus&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen

Comment 1 Radar WebKit Bug Importer 2022-11-18 10:46:41 PST

<rdar://problem/102522154>

Comment 2 Robert Jenner 2022-12-06 16:13:15 PST

It looks like the 256812@main regression point also caused:

TestWebKitAPI.FullscreenVideoTextRecognition.DoNotAnalyzeVideoAfterExitingFullscreen 

to fail as seen here:

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen

Comment 3 Ryan Haddad 2022-12-22 10:19:25 PST

Pull request: https://github.com/WebKit/WebKit/pull/8008

Comment 4 EWS 2022-12-22 13:45:27 PST

Test gardening commit 258258@main (b39597863656): <https://commits.webkit.org/258258@main>

Reviewed commits have been landed. Closing PR #8008 and removing active labels.

Comment 5 Tim Nguyen (:ntim) 2023-01-24 17:31:17 PST

*** Bug 251027 has been marked as a duplicate of this bug. ***

Comment 6 Ryan Haddad 2023-01-27 14:41:48 PST


*** This bug has been marked as a duplicate of bug 251247 ***