| Summary: | [LFC][IFC] Fix css2.1/t0805-c5520-brdr-b-01-e.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 248064 | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-11-18 10:39:43 PST
Created attachment 463607 [details]
Patch
Comment on attachment 463607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463607&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:199 > + auto listMarkerIsNested = enclosingListItem != associatedListItem; Can these both be null? I notice we are using pointers for both. (In reply to Darin Adler from comment #2) > Comment on attachment 463607 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463607&action=review > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:199 > > + auto listMarkerIsNested = enclosingListItem != associatedListItem; > > Can these both be null? I notice we are using pointers for both. No, we don't expect neither of them null during layout (that would indicate a detached subtree). Committed 256858@main (7a26f091845d): <https://commits.webkit.org/256858@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463607 [details]. |