Bug 248088
| Summary: | FRAME and FRAMESET should always be in-flow (and non-floating) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking at Chrome / Blink "styleadjusder", I noticed the following commit, which fixes some crash fixes stemming from confusing rendering engine:
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/f47b628e85e5195efc1f152c2bc7a19d20c85fa0
Webkit GitHub - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/style/StyleAdjuster.cpp#LL290
Just trying to raise this bug so I can do another merge to make Webkit more reliable.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
(In reply to Ahmad Saleem from comment #0)
> Hi Team,
>
> While looking at Chrome / Blink "styleadjusder", I noticed the following
> commit, which fixes some crash fixes stemming from confusing rendering
> engine:
>
> Blink Commit -
> https://chromium.googlesource.com/chromium/src.git/+/
> f47b628e85e5195efc1f152c2bc7a19d20c85fa0
>
> Webkit GitHub -
> https://github.com/WebKit/WebKit/blob/main/Source/WebCore/style/
> StyleAdjuster.cpp#LL290
>
> Just trying to raise this bug so I can do another merge to make Webkit more
> reliable.
>
> Thanks!
*StyleAdjuster.cpp
Radar WebKit Bug Importer
<rdar://problem/102670652>
Ahmad Saleem
Mozilla Firefox has it as well - https://searchfox.org/mozilla-central/rev/a59018f9ff34170810b43e12bf6f09a1512de7ab/layout/style/res/html.css#652
frameset {
display: block ! important;
overflow: clip;
position: static ! important;
float: none ! important;
border: none ! important;
}
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/42901
EWS
Committed 296236@main (c3c083fd5897): <https://commits.webkit.org/296236@main>
Reviewed commits have been landed. Closing PR #42901 and removing active labels.