Bug 248065

Summary: REGRESSION(?): [iOS] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies()
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Website StorageAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ben_schwartz, Hironori.Fujii, sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
crash log none

Description Ryan Haddad 2022-11-17 16:07:34 PST 
imported/w3c/web-platform-tests/service-workers/cache-storage/cross-partition.https.tentative.html has been a flaky crash on iOS since it was added with the WPT sync in https://commits.webkit.org/256529@main

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebcodecs%2Ffull-cycle-test.https.any.html%3Fh264_avc&platform=ios
Comment 1 Radar WebKit Bug Importer 2022-11-17 16:07:46 PST 
<rdar://problem/102490719>
Comment 2 Ryan Haddad 2022-11-17 16:12:30 PST 
Created attachment 463594 [details]
crash log

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   JavaScriptCore                	       0x136623f4e WTFCrash + 14 (Assertions.cpp:327)
1   WebKit                        	       0x119aca40b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:754)
2   WebKit                        	       0x11a9d14c3 WebKit::NetworkProcess::allowsFirstPartyForCookies(WTF::ObjectIdentifier<WebCore::ProcessIdentifierType>, WTF::URL const&) + 579 (NetworkProcess.cpp:422)
Comment 3 Ryan Haddad 2022-11-17 16:13:19 PST 
ASSERTION FAILED: result
/Volumes/Data/worker/Apple-iOS-16-Simulator-Debug-Build/build/Source/WebKit/NetworkProcess/NetworkProcess.cpp(422) : bool WebKit::NetworkProcess::allowsFirstPartyForCookies(WebCore::ProcessIdentifier, const WTF::URL &)
Comment 4 EWS 2022-11-17 16:21:00 PST 
Test gardening commit 256810@main (ebc8d0272489): <https://commits.webkit.org/256810@main>

Reviewed commits have been landed. Closing PR #6614 and removing active labels.
Comment 5 Fujii Hironori 2022-11-19 05:52:57 PST 
255420@main (bug#244068) added the assertion.
Comment 6 youenn fablet 2023-01-25 08:05:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9113
Comment 7 EWS 2023-01-26 03:47:31 PST 
Committed 259417@main (1b0d8f7b12c4): <https://commits.webkit.org/259417@main>

Reviewed commits have been landed. Closing PR #9113 and removing active labels.
Comment 8 Ben Schwartz 2024-05-31 17:22:02 PDT 
This no longer appears to be occurring. Removing test expectations. Please file a new bug if issues persist.

Tracking test expectations removal in bug #274990 (rdar://129080660).