Bug 248046

Summary: Comment Update in WebCore & JSC should not go through EWS Pipeline
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 248037    

Description Ahmad Saleem 2022-11-17 10:21:02 PST 
Hi Team,

Another suggestion would be if any change within WebCore or JSC or other areas are just comments.

//xxx something (can be used same functionality used by Style Checker) then if EWS queues can be avoided or if something like "Reviewed by OOPs" where if add "Comment Update by OOPs" something.

I don't know any PR where there were just comment updates but it could be one edge case, which if can be added while trying to optimize, it can lead to future EWS resource saving.

Thanks!
Comment 1 Alexey Proskuryakov 2022-11-17 19:29:42 PST 
Yes, this does seem like a rare edge case to me, probably not worth additional code complexity.
Comment 2 Aakash Jain 2022-11-18 08:21:26 PST 
We recently (just yesterday in https://commits.webkit.org/256760@main) added ability to skip ews on PRs by manually adding "skip-ews" label.

If for whatever reason, someone thinks that a PR doesn't need EWS coverage, they can manually add skip-ews label on the GitHub PR (to skip EWS).