Bug 248042

Summary: Background Queue monitor to remove outdated hashes of PR from queue and update timeline
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 248037    

Description Ahmad Saleem 2022-11-17 09:02:02 PST 
Hi Team,

Another improvement to EWS (at least to user from psychology point of view - might be zero tangible benefit), it would be to run another background script on all queue PRs for build requests and check every 10 minutes or 20 minutes (can be tweaked) to ensure that if any PR has build request but now it is update or outdated build hash then remove it from the queue.

This will help for those EWS system (e.g., mac-wk1 etc.), which take time or slow because with background script running and removing outdated hashes from queue, it will not show 18 hours queue to contributors and demotivate them.

With showing just six hours queue since now it has clean all outdated hashes from build pipeline, it would be good and smarter approach IMO.

Again - I am just suggesting but the pros and cons from inside knowledge can be validated by Tools team from Apple.

Thanks!
Comment 1 Jonathan Bedard 2022-11-17 10:08:15 PST 
If we were going to do this, we should do it on hook reception instead of polling.

That being said, it's less of a benefit than you might think because the very first thing every queue does before running a job is check if the PR and commit it's running on are stale.
Comment 2 Ahmad Saleem 2022-11-17 10:14:01 PST 
(In reply to Jonathan Bedard from comment #1)
> If we were going to do this, we should do it on hook reception instead of
> polling.
> 
> That being said, it's less of a benefit than you might think because the
> very first thing every queue does before running a job is check if the PR
> and commit it's running on are stale.

Indeed! Hence I said in first line (psychology point of view - might be zero tangible benefit).. 😆
Comment 3 Radar WebKit Bug Importer 2022-11-24 09:02:16 PST 
<rdar://problem/102649650>