Bug 248039

Summary:	Smarter EWS Checks for METADATA directory
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	aakash_jain, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	248037

Description Ahmad Saleem 2022-11-17 08:36:49 PST

Hi Team,

Again in continuation with our discussion in Webkit Contributors conference, I think it was mentioned that METADATA Directory is special and it has linkage / integration with other systems and something can be done to optimise it better while not going through EWS build check ordeal.

I am just raising this bug to evaluate on how Build Scripts can be optimised to not perform any extensive BUILD tests but just integration testings to free EWS resources for other tasks.

I can be completely wrong and there might be valid use cases for those but again the purposes is to bring all ideas or suggestion to one window. Hence, I am raising these bugs.

Thanks!

Comment 1 Jonathan Bedard 2022-11-17 10:16:34 PST

*** Bug 248038 has been marked as a duplicate of this bug. ***

Comment 2 Jonathan Bedard 2022-11-17 10:17:29 PST

This is a good idea, would just be a modification of CheckChangeRelevance in `Tools/CISupport/ews-build/steps.py`, I believe.

Comment 3 Ahmad Saleem 2022-11-17 10:29:24 PST

(In reply to Jonathan Bedard from comment #2)
> This is a good idea, would just be a modification of CheckChangeRelevance in
> `Tools/CISupport/ews-build/steps.py`, I believe.

Can we also update documentation / instruction wherever (if you can point) for committer access to not raise bug and just raise PR directly?

Just bringing this from other bug since I want to strike two birds with one stone.

-> Less Bugs on Bugzilla about adding to Contributor.json file

Comment 4 Aakash Jain 2022-11-18 08:37:26 PST

Currently (in CheckChangeRelevance) we have only concept of queues defining which directories/files are relevant to them. For that we have mapping of queue-name => list-of-relevant-paths.

We don't currently have a way to define if a PR/patch has only specific files, then run it only on specific queues.

We can add such a way, just need to be sure that it's worth it and we implement in right manner (by adding a mapping file/directory => queue mapping appropriately). Note that we do have such a mapping for build.webkit.org (in https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/build-webkit-org/wkbuild.py#L59)

Comment 5 Radar WebKit Bug Importer 2022-11-24 08:37:12 PST

<rdar://problem/102649183>