Bug 248018

Summary:	REGRESSION(256180@main): Enabling accelerated drawing caused some ImageOnly Failures
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	nmouchtaris, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=246285

Description Robert Jenner 2022-11-16 20:51:54 PST

It looks like enabling accelerated drawing at 256180@main caused the following 15 tests to have constant ImageOnly Failures:


compositing/geometry/css-clip-oversize.html
compositing/hidpi-compositing-layer-with-tile-layers-on-subpixel-position.html
compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html
css3/blending/background-blend-mode-data-uri-svg-image.html
fast/borders/border-painting-inset.html
fast/borders/border-painting-outset.html
fast/borders/hidpi-border-painting-groove.html
fast/borders/hidpi-border-painting-ridge.html
fast/borders/wrong-border-color-when-radius-is-present.html
fast/box-shadow/inset-shadow-split-inline.html
fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html
imported/blink/fast/sub-pixel/sub-pixel-transparency-layer.html
imported/mozilla/svg/path-02.svg
imported/w3c/web-platform-tests/css/css-transforms/transforms-skewY.html
imported/w3c/web-platform-tests/svg/extensibility/foreignObject/masked.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=compositing%2Fgeometry%2Fcss-clip-oversize.html&test=compositing%2Fhidpi-compositing-layer-with-tile-layers-on-subpixel-position.html&test=compositing%2Fscrolling%2Fasync-overflow-scrolling%2Fborder-radius-on-scroll-container.html&test=css3%2Fblending%2Fbackground-blend-mode-data-uri-svg-image.html&test=fast%2Fborders%2Fborder-painting-inset.html&test=fast%2Fborders%2Fborder-painting-outset.html&test=fast%2Fborders%2Fhidpi-border-painting-groove.html&test=fast%2Fborders%2Fhidpi-border-painting-ridge.html&test=fast%2Fborders%2Fwrong-border-color-when-radius-is-present.html&test=fast%2Fbox-shadow%2Finset-shadow-split-inline.html&test=fast%2Flayers%2Fparent-clipping-overflow-is-overwritten-by-child-clipping.html&test=imported%2Fblink%2Ffast%2Fsub-pixel%2Fsub-pixel-transparency-layer.html&test=imported%2Fmozilla%2Fsvg%2Fpath-02.svg&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Ftransforms-skewY.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Fextensibility%2FforeignObject%2Fmasked.html


URL TO RESULTS PAGE:
https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK2-Tests/256760@main%20(175)/results.html

Comment 1 Radar WebKit Bug Importer 2022-11-16 20:52:52 PST

<rdar://problem/102449694>

Comment 2 Robert Jenner 2022-11-16 20:54:58 PST

The ImageDiff for all of these tests appear to only be off by .01%. Still, I was able to reproduce them all at Ventura Debug ToT running the test as follows:


run-webkit-tests <insert test name here>

I also was able to determine that the regression point where these failures were introduced is 256180@main. The failures did not reproduce at 256179@main

Comment 3 Robert Jenner 2022-11-16 20:57:53 PST

Starting on Nikos who introduced https://commits.webkit.org/256180@main that caused these ImageOnlyFailures.

Comment 4 Robert Jenner 2022-11-17 12:04:40 PST

Pull request: https://github.com/WebKit/WebKit/pull/6598

Comment 5 EWS 2022-11-18 11:44:00 PST

Committed 256844@main (6409da485414): <https://commits.webkit.org/256844@main>

Reviewed commits have been landed. Closing PR #6598 and removing active labels.

Comment 6 Robert Jenner 2022-11-28 13:18:39 PST

Re-opening for pull request https://github.com/WebKit/WebKit/pull/6877

Comment 7 Robert Jenner 2022-11-28 13:20:14 PST

(In reply to Robert Jenner from comment #6)
> Re-opening for pull request https://github.com/WebKit/WebKit/pull/6877

There was an additional fix needed for:

compositing/geometry/css-clip-oversize.html
fast/borders/border-painting-inset.html
fast/borders/border-painting-outset.html
fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html

So I have submitted a PR for them above.

Comment 8 EWS 2022-11-29 22:43:27 PST

Committed 257168@main (543c335f8661): <https://commits.webkit.org/257168@main>

Reviewed commits have been landed. Closing PR #6877 and removing active labels.

Comment 9 Robert Jenner 2022-11-29 22:52:52 PST

Re-opening for pull request https://github.com/WebKit/WebKit/pull/6959

Comment 10 EWS 2022-12-01 00:05:35 PST

Committed 257224@main (4ef04177be59): <https://commits.webkit.org/257224@main>

Reviewed commits have been landed. Closing PR #6959 and removing active labels.

Comment 11 Robert Jenner 2022-12-02 11:37:25 PST

svg/gradients/spreadMethodAlpha.svg
svg/custom/hidpi-masking-clipping.svg
svg/compositing/outermost-svg-with-border-padding.html

Look like they all need tolerance adjustments.

Comment 12 EWS 2023-01-27 17:41:51 PST

Test gardening commit 259518@main (bb5fff6456b0): <https://commits.webkit.org/259518@main>

Reviewed commits have been landed. Closing PR #9266 and removing active labels.

Comment 13 EWS 2023-01-31 14:15:22 PST

Test gardening commit 259646@main (ee8e4757570e): <https://commits.webkit.org/259646@main>

Reviewed commits have been landed. Closing PR #9407 and removing active labels.

Comment 14 Jonathan Bedard 2023-02-02 09:13:18 PST

Re-opening for pull request https://github.com/apple/WebKit/pull/346

Comment 15 EWS 2023-02-02 09:28:57 PST

Test gardening commit 259548.37@safari-7615-branch (a96eb9fd3417): <https://commits.webkit.org/259548.37@safari-7615-branch>

Reviewed commits have been landed. Closing PR #346 and removing active labels.