Bug 247982

Summary: REGRESSION (251289@main): [ Ventura ] fast/images/animated-heics-draw.html is a consistent timeout
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: pvollan, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Karl Rackler 2022-11-16 08:24:38 PST
Description:
fast/images/animated-heics-draw.html

The first failure I saw on the dashboard was on 11/4/2022 at 256337@main.

This issue can be bisected to 251289@main using the command: 
run-webkit-tests --debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry fast/images/animated-heics-draw.html

Result: 
Regressions: Unexpected timeouts (1)
  fast/images/animated-heics-draw.html [ Timeout ]

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Fanimated-heics-draw.html

Diff:
--- /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/fast/images/animated-heics-draw-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/fast/images/animated-heics-draw-actual.txt
@@ -1,14 +1,8 @@
+FAIL: Timed out waiting for notifyDone to be called
+
 Verify HEICS image can animate.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Image was loaded successfully.
-Image frame: 0 was displayed.
-Image frame: 1 was displayed.
-Image frame: 2 was displayed.
-The HEICS Image was loaded and three frames of it were displayed successfully.
-PASS successfullyParsed is true
 
-TEST COMPLETE
-
Comment 1 Radar WebKit Bug Importer 2022-11-16 08:25:17 PST
<rdar://problem/102421055>
Comment 2 Karl Rackler 2022-11-16 08:33:28 PST
I have marked this test as a consistent timeout while this issue is investigated.
Comment 3 Karl Rackler 2022-11-16 08:41:51 PST
Pull request: https://github.com/WebKit/WebKit/pull/6554
Comment 4 EWS 2022-11-16 08:45:31 PST
Test gardening commit 256735@main (9d37767bbcc9): <https://commits.webkit.org/256735@main>

Reviewed commits have been landed. Closing PR #6554 and removing active labels.
Comment 5 Per Arne Vollan 2022-11-16 11:15:57 PST
Pull request: https://github.com/WebKit/WebKit/pull/6558
Comment 6 EWS 2022-11-16 12:40:29 PST
Test gardening commit 256748@main (89a1de42b347): <https://commits.webkit.org/256748@main>

Reviewed commits have been landed. Closing PR #6559 and removing active labels.
Comment 7 EWS 2022-11-17 15:16:02 PST
Committed 256803@main (cb95bbf8fb0f): <https://commits.webkit.org/256803@main>

Reviewed commits have been landed. Closing PR #6558 and removing active labels.
Comment 8 Karl Rackler 2022-11-29 08:27:47 PST
After landing 256803@main the test is still a consistent timeout on Ventura.
Comment 10 Karl Rackler 2022-12-05 06:07:26 PST
Re-opening.  This was mistakenly closed, with the issue persisting due to a mixup on the test spot check. 

< rdar://102979844 >
Comment 11 Karl Rackler 2022-12-05 06:08:19 PST
See comment 10
Comment 12 Karl Rackler 2022-12-05 06:26:08 PST
Revert 256803@main that caused the test to flaky crash.
Comment 13 EWS 2022-12-05 06:28:04 PST
Committed 257368@main (bf51ac10e9b1): <https://commits.webkit.org/257368@main>

Reviewed commits have been landed. Closing PR #7146 and removing active labels.
Comment 14 EWS 2022-12-05 06:37:53 PST
Test gardening commit 257369@main (a147a604e46d): <https://commits.webkit.org/257369@main>

Reviewed commits have been landed. Closing PR #7147 and removing active labels.
Comment 15 Karl Rackler 2022-12-05 06:46:14 PST
This flaky crash can be bisected to 256803@main using the command: 
run-webkit-tests --debug --iterations 2000 --debug-rwt-logging --no-retry --force --no-build -f fast/images/animated-heics-verify.html

The above can also reproduce the consistent timeout.