Bug 247963

Summary: [Ventura] Many layout tests exiting due to GPU process "crashes"
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Miguel Salinas <miguel_salinas>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, magomez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test list none

Description Ryan Haddad 2022-11-15 16:42:32 PST 
We're seeing many tests "crashing" without crashlogs on Ventura, with only the following in stderr

No crash log found for com.apple.WebKit.GPU.Development:82267.

stdout:

stderr:
com.apple.WebKit.GPU.Development terminated (pid 82267) for reason: crash

https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/256705@main%20(193)/results.html
Comment 1 Radar WebKit Bug Importer 2022-11-15 16:43:09 PST 
<rdar://problem/102393706>
Comment 2 Chris Dumez 2022-11-15 16:45:46 PST 
@Miguel: I looked at the logs and the issue is that the GPUProcess is getting suspended by RunningBoard while holding locked files.

Note that as far as I know, we don't expect process suspension on macOS at the moment so this is an issue.

Also note that this is with an open source SDK, where you recently disabled our RunningBoard code at runtime.

However, I suspect this issue is with:
Source/WebKit/Scripts/update-info-plist-for-runningboard.sh

Which updates our plist to opt into running board management and this logic likely still applies to the open source SDK builds, even though you completely disabled our RunningBoard logic there.
Comment 3 Chris Dumez 2022-11-15 16:47:09 PST 
(In reply to Chris Dumez from comment #2)
> @Miguel: I looked at the logs and the issue is that the GPUProcess is
> getting suspended by RunningBoard while holding locked files.
> 
> Note that as far as I know, we don't expect process suspension on macOS at
> the moment so this is an issue.
> 
> Also note that this is with an open source SDK, where you recently disabled
> our RunningBoard code at runtime.

*at build time*
Comment 4 Ryan Haddad 2022-11-15 16:47:23 PST 
Created attachment 463546 [details]
test list

I can reproduce this on a (customer) Ventura install with the attached test list

./Tools/Scripts/run-webkit-tests --test-list <path-to-download>/repro-crash --no-retry
Comment 5 Miguel Salinas 2022-11-15 19:36:05 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6537
Comment 6 EWS 2022-11-15 21:09:52 PST 
Committed 256719@main (60d2086f9b70): <https://commits.webkit.org/256719@main>

Reviewed commits have been landed. Closing PR #6537 and removing active labels.
Comment 7 Ryan Haddad 2022-11-16 09:28:03 PST 
I can confirm that this has cleared up the crashes that we were seeing on the bots. Thank you!