Bug 247918

Summary:	Change ReplaceSelectionCommand::moveNodeOutOfAncestor() to avoid hitting assertion while trying replace selection
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	HTML Editing	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rniwa, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2022-11-14 14:36:30 PST

Hi Team,

While going through Blink Commits, I came across crash fix in HTML Editing, which can also fix few assertion bugs in Webkit:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=153031&view=revision

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b308d25de831f4b7d9c1d643fd166417ef4a5c5e/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L837

Add:

if (!protectedAncestor->parentNode()->hasEditableStyle())

Just wanted to raise to fix it.

Thanks!

Comment 1 EWS 2022-11-14 19:51:17 PST

Committed 256682@main (531d3679e268): <https://commits.webkit.org/256682@main>

Reviewed commits have been landed. Closing PR #6489 and removing active labels.

Comment 2 Radar WebKit Bug Importer 2022-11-14 19:52:18 PST

<rdar://problem/102349687>