Bug 247859
| Summary: | Add floats to overflow of the direct containing block only | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I found another potential fix, which can be brought to Webkit:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/5b8a044ea5e398a0863d28c38855adcbd1a421c5
Webkit GitHub - https://github.com/WebKit/WebKit/blob/5a9504aef82d929917a680a05a3fc17f7f6b4dde/Source/WebCore/rendering/RenderBlockFlow.cpp#LL2144
and it should be changed from:
floatingObject.isDescendant()
to
floatingObject.shouldPaint()
______
Just wanted to raise it to fix this bug. Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
If I read following bug clearly:
This was final revision to the related bug - https://chromium.googlesource.com/chromium/src/+/0f639ede1ca727f4684766ec2427a341e413be7b
and it mentions that this was fixed with this:
https://chromium.googlesource.com/chromium/src/+/f01027994dbd35c1657c31d99045b45edff373fe
and this current commit was in reference to other approach of bug fixing. I am running this via EWS to see, if we get any passes else, I will close this bug. Thanks!
Radar WebKit Bug Importer
<rdar://problem/102559813>