| Summary: | Get rid of subtract-one-whole-pixel hack in Multi-column | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://jsfiddle.net/7ouv0qbr/show | ||
|
Description
Ahmad Saleem
2022-11-13 04:02:05 PST
LayoutUnit repaintLogicalBottom = (isHorizontalWritingMode() ? fragmentedFlowRepaintRect.maxY() : fragmentedFlowRepaintRect.maxX());
// Figure out the start and end columns for the layer and only check within that range so that
// we don't walk the entire column row.
unsigned startColumn;
unsigned endColumn;
columnIntervalForBlockRangeInFragmentedFlow(repaintLogicalTop, repaintLogicalBottom, startColumn, endColumn);
and
void RenderMultiColumnSet::columnIntervalForBlockRangeInFragmentedFlow(LayoutUnit logicalTopInFragmentedFlow, LayoutUnit logicalBottomInFragmentedFlow, unsigned& firstColumn, unsigned& lastColumn) const
{
ASSERT(logicalTopInFragmentedFlow <= logicalBottomInFragmentedFlow);
firstColumn = columnIndexAtOffset(logicalTopInFragmentedFlow);
lastColumn = columnIndexAtOffset(logicalBottomInFragmentedFlow);
// logicalBottomInFragmentedFlow is an exclusive endpoint, so some additional adjustments may be necessary.
if (lastColumn > firstColumn && LayoutUnit(logicalTopInFragmentedFlow(lastColumn)) == LayoutUnit(logicalBottomInFragmentedFlow))
--lastColumn;
}
__
^ this might work. Didn't tried.
__
I attached unprefixed test case in URL field.
|