Bug 247834
| Summary: | Fix comparison between two vectors with different inline capacity | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I came across another potential Blink Commit, where Webkit is still using old one.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/378ddcc6e178ab7ab43e01f55abfeb2f164bd0ff
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/125577b7ea29fabfde65c24ef617fa9a684acc3b/Source/WTF/wtf/Vector.h#LL229
I just wanted to post this for others to comment whether it is something needed in Webkit or not.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Our code is different, we don't take the shortcut based on pointer being null. I don't think that we ever had this error, must have been introduced by Blink after forking.