Bug 247802
| Summary: | RemoteAudioDestinationProxy base class is platform specific | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Media | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kimmo Kinnunen
RemoteAudioDestinationProxy base class is platform specific
Remote proxies in general should work on all platforms.
The platform specificness causes ifdefing.
The ifdefing in the RemoteAudioDestinationProxy causes ifdefing for in RemoteAudioDestinationManager messages.
Ifdefing in messages is problematic as the argument ifdefs cause new message names and that gets unmanageable.
All this is because GStreamer does not yet use RemoteAudioDestinationProxy but still compiles it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102238646>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/6396
EWS
Committed 256729@main (3fac3faf1d5b): <https://commits.webkit.org/256729@main>
Reviewed commits have been landed. Closing PR #6396 and removing active labels.