Bug 247729

Summary: Messages passing shared CARingBuffer handle pass also the frame count
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: MediaAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Kimmo Kinnunen 2022-11-10 05:50:42 PST
Messages passing shared CARingBuffer handle pass also the frame count

This makes the messages more convoluted than needed.
The number of frames is inherent property of the buffer, and should be part of the buffer handle.
Contrast to SharedMemory::Handle, which passes the mach port as well as the expected memory area size.
Comment 1 Radar WebKit Bug Importer 2022-11-10 05:51:24 PST
<rdar://problem/102190399>
Comment 2 Kimmo Kinnunen 2022-11-10 05:59:45 PST
Pull request: https://github.com/WebKit/WebKit/pull/6286
Comment 3 Kimmo Kinnunen 2022-11-10 08:01:54 PST
Pull request: https://github.com/WebKit/WebKit/pull/6349
Comment 4 EWS 2022-11-15 06:42:44 PST
Committed 256693@main (a1fc3fc6f009): <https://commits.webkit.org/256693@main>

Reviewed commits have been landed. Closing PR #6349 and removing active labels.