Bug 247653
| Summary: | Create a temporary 'Grid' for computeIntrinsicLogicalWidths in RenderGrid. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, joncarlo, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Woodrow
<rdar://101965460>
RenderGrid::computeIntrinsicLogicalWidths currently operates on the same Grid (for item placement) as is used by normal layout. This can cause issues, since we don't expect the layout of the RenderElement to be changed by this function.
We can instead create a stack-based temporary Grid for this, and operate on that for the intrinsic size calculation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/6275
EWS
Committed 256624@main (7b600312f1e1): <https://commits.webkit.org/256624@main>
Reviewed commits have been landed. Closing PR #6275 and removing active labels.
EWS
Committed 252432.895@safari-7614-branch (a9431fcabf85): <https://commits.webkit.org/252432.895@safari-7614-branch>
Reviewed commits have been landed. Closing PR #228 and removing active labels.
JC Alvarado
*** Bug 247633 has been marked as a duplicate of this bug. ***