Bug 247653

Summary:	Create a temporary 'Grid' for computeIntrinsicLogicalWidths in RenderGrid.
Product:	WebKit	Reporter:	Matt Woodrow <mattwoodrow>
Component:	Layout and Rendering	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, joncarlo, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Matt Woodrow 2022-11-08 16:02:07 PST

<rdar://101965460>

RenderGrid::computeIntrinsicLogicalWidths currently operates on the same Grid (for item placement) as is used by normal layout. This can cause issues, since we don't expect the layout of the RenderElement to be changed by this function.

We can instead create a stack-based temporary Grid for this, and operate on that for the intrinsic size calculation.

Comment 1 Matt Woodrow 2022-11-08 16:22:58 PST

Pull request: https://github.com/WebKit/WebKit/pull/6275

Comment 2 EWS 2022-11-13 19:09:32 PST

Committed 256624@main (7b600312f1e1): <https://commits.webkit.org/256624@main>

Reviewed commits have been landed. Closing PR #6275 and removing active labels.

Comment 3 EWS 2022-12-05 08:29:10 PST

Committed 252432.895@safari-7614-branch (a9431fcabf85): <https://commits.webkit.org/252432.895@safari-7614-branch>

Reviewed commits have been landed. Closing PR #228 and removing active labels.

Comment 4 JC Alvarado 2023-01-06 13:42:57 PST

*** Bug 247633 has been marked as a duplicate of this bug. ***