Bug 247514

Summary: Fix MaxCoefficient static variable value in Decimal.cpp
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=248784

Description Ahmad Saleem 2022-11-04 17:51:05 PDT 
Hi Team,

Just going through Blink Commits, came across following commit:

Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174294

and Webkit is still using wrong one, I think matching would be fine rather than updating comment to reflect current value.

https://github.com/WebKit/WebKit/blob/06829a72816b3507674af7be8a740a4964ae3518/Source/WebCore/platform/Decimal.cpp#L51

I am just creating this bug to do PR and merge above commit.

Let me know if someone want me to just update comment.

Thanks!
Comment 1 Alexey Proskuryakov 2022-11-09 10:09:43 PST 
ch.dumez@samsung.com! Sadly, no test modified in the commit.
Comment 2 Ahmad Saleem 2022-11-09 10:32:37 PST 
(In reply to Alexey Proskuryakov from comment #1)
> ch.dumez@samsung.com! Sadly, no test modified in the commit.

https://github.com/WebKit/WebKit/pull/6160
Comment 3 Ahmad Saleem 2022-11-09 10:33:50 PST 
(In reply to Ahmad Saleem from comment #2)
> (In reply to Alexey Proskuryakov from comment #1)
> > ch.dumez@samsung.com! Sadly, no test modified in the commit.
> 
> https://github.com/WebKit/WebKit/pull/6160

Latest position is that whether there is std:decimal to replace our use case or whether we just add 'DecmialTest.cpp' API for testing similar to Chrome.
Comment 4 Chris Dumez 2022-11-09 10:56:39 PST 
(In reply to Alexey Proskuryakov from comment #1)
> ch.dumez@samsung.com! Sadly, no test modified in the commit.

There were tests modified in MY commit :)
Comment 5 Radar WebKit Bug Importer 2022-11-11 16:52:17 PST 
<rdar://problem/102261978>
Comment 6 Ahmad Saleem 2022-12-20 08:41:30 PST 
Will fix via https://github.com/WebKit/WebKit/pull/7908 in one go with test-case as well.
Comment 7 Brent Fulgham 2024-01-23 16:52:16 PST 

*** This bug has been marked as a duplicate of bug 248784 ***