| Summary: | StyleProperties::fontValue needs to return emptyString in many more cases where font sub properties have unusual values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | CSS | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, mmaxfield, ntim, obrufau, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=247810 https://bugs.webkit.org/show_bug.cgi?id=217625 https://bugs.webkit.org/show_bug.cgi?id=87129 |
||
|
Description
Darin Adler
2022-11-04 12:27:18 PDT
A significant part of the work here is to add test cases, preferably WPT tests. I’m not actually sure what the desired behavior is here. I might need someone’s help to write the tests before changing any of the code. Tim, what do you think? > I’m not actually sure what the desired behavior is here. https://github.com/w3c/csswg-drafts/issues/8062 The font shorthand serialization should be empty when the subproperties are not representable by the shorthand. We seem to have similar issues with other props too, see bug 247810 I am working on a patch for this right now. Tim, hope you weren’t already working on it. The part I was not clear on was the "implicit" flag bit. Pull request: https://github.com/WebKit/WebKit/pull/6426 Committed 256635@main (d3d6e16bf1f0): <https://commits.webkit.org/256635@main> Reviewed commits have been landed. Closing PR #6426 and removing active labels. *** Bug 169259 has been marked as a duplicate of this bug. *** |