Bug 247465

Summary: Grid track sizing should reset the override width as well as height to compute intrinsic sizing
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: Layout and RenderingAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Matt Woodrow 2022-11-03 16:37:07 PDT
Grid layout (sometimes) sets the override content size and containing block sizes, so that grid items get sized relative to their grid tracks, rather than the size of the grid element.

During the sizing process, we want to know the intrinsic size of children, so we reset any overrides and re-layout children to measure them.

We're currently not resetting the content logical width, and there's a comment saying that grid never uses it, but that's out of date and we do need to reset this.

<rdar://101304306>
Comment 1 Matt Woodrow 2022-11-03 17:58:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/6114
Comment 2 EWS 2022-11-13 16:01:06 PST
Committed 256622@main (f2e73e71c88c): <https://commits.webkit.org/256622@main>

Reviewed commits have been landed. Closing PR #6114 and removing active labels.