Bug 247400

Summary: AX ITM: fix for aria-activedescendant tests in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2022-11-02 18:19:33 PDT
Currently failing in ITM.
Attachments
Patch (6.39 KB, patch)
2022-11-02 18:33 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (12.17 KB, patch)
2022-11-03 08:07 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (12.17 KB, patch)
2022-11-03 08:14 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-11-02 18:19:57 PDT
<rdar://problem/101889227>
Andres Gonzalez
Comment 2 2022-11-02 18:33:57 PDT
Created attachment 463374 [details] Patch
Tyler Wilcock
Comment 3 2022-11-02 18:42:34 PDT
Comment on attachment 463374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463374&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1893 > + updateIsolatedTree(*object, AXNotification::AXActiveDescendantChanged); If document().focusedElement() == element, we will do this below: postNotification(target, &document(), AXActiveDescendantChanged); Causing a duplicated isolated tree update. Should we try to avoid this duplicate update somehow? > Source/WebCore/accessibility/AXObjectCache.cpp:1896 > + // NOtify active descendant changes only for the focused element. Typo here, capital O in "NOtify"
Andres Gonzalez
Comment 4 2022-11-03 08:07:10 PDT
Created attachment 463388 [details] Patch
Andres Gonzalez
Comment 5 2022-11-03 08:14:06 PDT
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 463374 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=463374&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:1893 > > + updateIsolatedTree(*object, AXNotification::AXActiveDescendantChanged); > > If document().focusedElement() == element, we will do this below: > > postNotification(target, &document(), AXActiveDescendantChanged); > > Causing a duplicated isolated tree update. Should we try to avoid this > duplicate update somehow? Yes, we should actually call postPlatformNotification instead. This made apparent the need to also update the target element when it is different from the original element. > > > Source/WebCore/accessibility/AXObjectCache.cpp:1896 > > + // NOtify active descendant changes only for the focused element. > > Typo here, capital O in "NOtify" Fixed in latest patch.
Andres Gonzalez
Comment 6 2022-11-03 08:14:47 PDT
Created attachment 463389 [details] Patch
EWS
Comment 7 2022-11-03 10:54:20 PDT
Committed 256279@main (3b4b837022dc): <https://commits.webkit.org/256279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463389 [details].
Note You need to log in before you can comment on or make changes to this bug.