Bug 247360

Summary:	Constructing shared CARingBuffer cannot fail
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	Media	Assignee:	Kimmo Kinnunen <kkinnunen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Kimmo Kinnunen 2022-11-02 05:30:20 PDT

Constructing shared CARingBuffer cannot fail

This is a problem because shared CARingBuffers are used cross-process, and the WP might send data that would construct a potentially invalid CARingBuffer.
This leads to code that uses empty instances instead of not checking all use-sites correctly. This in turn leads to running code that is expected to only run when the ring buffer is correct.

Comment 1 Radar WebKit Bug Importer 2022-11-02 05:30:40 PDT

<rdar://problem/101856691>

Comment 2 Kimmo Kinnunen 2022-11-02 05:56:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/6032

Comment 3 EWS 2022-11-03 08:23:29 PDT

Committed 256273@main (eece78fdf9b2): <https://commits.webkit.org/256273@main>

Reviewed commits have been landed. Closing PR #6032 and removing active labels.