Bug 247360
| Summary: | Constructing shared CARingBuffer cannot fail | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Media | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=277407 | ||
Kimmo Kinnunen
Constructing shared CARingBuffer cannot fail
This is a problem because shared CARingBuffers are used cross-process, and the WP might send data that would construct a potentially invalid CARingBuffer.
This leads to code that uses empty instances instead of not checking all use-sites correctly. This in turn leads to running code that is expected to only run when the ring buffer is correct.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101856691>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/6032
EWS
Committed 256273@main (eece78fdf9b2): <https://commits.webkit.org/256273@main>
Reviewed commits have been landed. Closing PR #6032 and removing active labels.