Bug 247342
| Summary: | [git-webkit] Print help when multiple unknown arguments are provided | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
In some commands, git-webkit forwards unknown arguments on to git itself. This means that argparse doesn't always recognize that a command is invalid because it will, in some cases, just return unknown arguments to be forwarded. Notably, this is the case for `git-webkit -pr --rebase`. If the user's arguments don't result in a program definition, we should print the help message and exit the program.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101830556>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/6014
EWS
Committed 256516@main (68e00a092301): <https://commits.webkit.org/256516@main>
Reviewed commits have been landed. Closing PR #6014 and removing active labels.
EWS
Committed 252432.829@safari-7614-branch (7cf9c2004005): <https://commits.webkit.org/252432.829@safari-7614-branch>
Reviewed commits have been landed. Closing PR #207 and removing active labels.